calico icon indicating copy to clipboard operation
calico copied to clipboard

Fix syncing calico node labels for Kubernetes CRD mode

Open huiyizzz opened this issue 3 years ago • 7 comments

Description

For Kubernetes CRD mode, sync labels should always be set to enabled. This PR adds a validation rule for syncLabels. When the datastore type is Kubernetes, it does not allow disabling sync labels.

Related issues/PRs

https://github.com/projectcalico/calico/issues/5594

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

huiyizzz avatar Sep 28 '22 23:09 huiyizzz

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 28 '22 23:09 CLAassistant

/sem-approve

coutinhop avatar Sep 29 '22 17:09 coutinhop

/sem-approve

coutinhop avatar Oct 12 '22 22:10 coutinhop

/sem-approve

coutinhop avatar Oct 13 '22 19:10 coutinhop

/sem-approve

coutinhop avatar Oct 17 '22 17:10 coutinhop

/sem-approve

coutinhop avatar Oct 18 '22 16:10 coutinhop

/sem-approve

mgleung avatar Oct 18 '22 22:10 mgleung

/sem-approve

mgleung avatar Oct 26 '22 23:10 mgleung

/sem-approve

mgleung avatar Oct 28 '22 17:10 mgleung

/sem-approve

mgleung avatar Oct 28 '22 18:10 mgleung