calico icon indicating copy to clipboard operation
calico copied to clipboard

Fix felix RPM build

Open mgleung opened this issue 3 years ago • 2 comments

Description

With the addition of https://github.com/projectcalico/calico/commit/283bb4b0378b84a45c896469e925698a6e445d55 in order to speed up our test builds, our RPM build script became unable to handle an unexpected bin/bpf directory. This specifies the correct felix binary for our RPM builds.

Related issues/PRs

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

mgleung avatar Aug 19 '22 19:08 mgleung

Deploy Preview for calico-v3-24 ready!

Name Link
Latest commit ae0d99a14deb7561cde7d711066be304089504e2
Latest deploy log https://app.netlify.com/sites/calico-v3-24/deploys/62ffdeb9718530000813f144
Deploy Preview https://deploy-preview-6586--calico-v3-24.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 19 '22 19:08 netlify[bot]

Deploy Preview for calico-tigera ready!

Name Link
Latest commit ae0d99a14deb7561cde7d711066be304089504e2
Latest deploy log https://app.netlify.com/sites/calico-tigera/deploys/62ffdeb904b76600081337f9
Deploy Preview https://deploy-preview-6586--calico-tigera.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 19 '22 19:08 netlify[bot]

@neiljerram , good point, I took a look at an older build and the only thing that I found was calico-felix so I think this should capture everything we need. My hunch is that we were using * in case the binary name changed, but I don't think it does so we should be fine.

mgleung avatar Aug 22 '22 18:08 mgleung

I took a look at an older build and the only thing that I found was calico-felix so I think this should capture everything we need. My hunch is that we were using * in case the binary name changed, but I don't think it does so we should be fine.

@mgleung Sounds good, thanks for checking that!

nelljerram avatar Aug 23 '22 09:08 nelljerram