[WIP] Propshaft Branch

[taylor-steve]

Drafting this as promised.

Current Usage

• Use bin/dev or the JS won't build
• BLACKLIGHT_VERSION and BOOTSTRAP_VERSION should work. If there's a mismatch between NPM and gem versions, yarn will prompt you to pick
• When using the template to generate a new app with rails new:
  • Don't let importmap:install overwrite application.js
  • yarn link in your Spotlight repo and yarn link "spotlight-frontend" in your generated app. This is not needed when using engine cart
• npm run prepare after JS changes in Spotlight and your app should update without a restart

Current State

In terms of direction, it's still all over the place but the test app builds with propshaft and passes (most) tests on locally BL7 & BL8:

• One failure because OSD won't initialize (band-aid: https://github.com/sul-dlss/openseadragon-rails/pull/5)
• Three Chromedriver related test failures if you have the version that ignores the alerts
• Lots of sleep 1 additions while identifying legit failures

Recently I've noticed a few quirks (turbo or bundler related) in the template generated app that I don't see in engine cart.

[dnoneill]

Couple of issues

• right now spotlight:server doesn't work
• CSS not loading or something, the pages don't look right.

[jcoyne]

It looks to me like this breaks sprockets bundling. So will this be a major version update?

[taylor-steve]

It looks to me like this breaks sprockets bundling. So will this be a major version update?

That's the current plan as I understand it.