blacklight icon indicating copy to clipboard operation
blacklight copied to clipboard

Arrange HTML so that the search bar is part of the main element

Open jcoyne opened this issue 1 year ago • 3 comments

Fixes #3252

jcoyne avatar Oct 24 '24 16:10 jcoyne

I'm not sure I understand the motivation for this change, but this seems like it could be incredibly disruptive to downstream applications are require a lot more overriding to recreate fairly common layout patterns:

Screenshot 2024-10-24 at 10 41 09

Screenshot 2024-10-24 at 10 41 24

Screenshot 2024-10-24 at 10 42 11

Screenshot 2024-10-24 at 10 42 56

cbeer avatar Oct 24 '24 17:10 cbeer

I agree that this may be a challenge for adopters to take on. I believe this provides better semantics for accessibility. I believe this was raised by Darcy when looking at Geoblacklight (see #3252).

While implementing this it felt like our existing layouts (with content_for) made this a challenge to implement easily.

jcoyne avatar Oct 24 '24 20:10 jcoyne

Let's close as won't do.

dbranchini avatar Jan 16 '25 21:01 dbranchini