blacklight icon indicating copy to clipboard operation
blacklight copied to clipboard

Allow generating when BUNDLE_PATH is set

Open jcoyne opened this issue 1 year ago • 3 comments

Fixes #3284

jcoyne avatar Aug 22 '24 16:08 jcoyne

I wonder what the heck that with_unbundled_env was for in the first place! Hopefully nothing it was an unneeded accidental addition?

jrochkind avatar Aug 22 '24 16:08 jrochkind

For code archeology... the code (in form of older method with_clean_env seems to have been added here:

https://github.com/projectblacklight/blacklight/commit/b3831f8cc8fa4d5e12a4f03d4d8058717d406d0e

With commit message just saying "Update install generators to explicitly run bundle install inside the destination_root". I don't totally understand what that means in this context.

By @cbeer . Should we check with @cbeer to see if he remembers the motivation or any reason this revert would break anything?

jrochkind avatar Aug 22 '24 16:08 jrochkind

with_unbundled_env was for in the first place!

I think the failing CI build demonstrates the kind of failure you get without it. If the CI build can be fixed, great 🤷‍♂️

cbeer avatar Aug 27 '24 14:08 cbeer