blacklight icon indicating copy to clipboard operation
blacklight copied to clipboard

Use Bootstrap 5 Accordion for the facet list

Open jcoyne opened this issue 1 year ago • 4 comments

Screenshot 2024-08-07 at 10 04 19 AM

This was not available in Bootstrap 4. It allows a lot more customization (via Bootstrap variables) and requires Blacklight itself to have less code.

jcoyne avatar Aug 07 '24 15:08 jcoyne

After this PR, does facet list still work with Bootstrap 4, or is this a clean break requiring Bootstrap 5?

If it's a clean break, and that's what the community wants, then please make sure that's clearly noted in release notes for version that includes this? Also to avoid confusion probably remove the config bootstrap_version, and possibly remove other support for bootstrap 4?

jrochkind avatar Aug 07 '24 15:08 jrochkind

@jrochkind this is only for BS 5 and it can be merged after https://github.com/projectblacklight/blacklight/pull/3226 is in place.

jcoyne avatar Aug 07 '24 16:08 jcoyne

This is how IU is styling this component: Screenshot 2024-10-16 at 10 27 18 AM

jcoyne avatar Oct 16 '24 15:10 jcoyne

We have long done similar styling in Blacklight 7/Boostrap 4, adding styles to make the facet menu look like this even in that situation.

Screenshot 2024-10-16 at 11 34 45 AM

https://digital.sciencehistory.org/catalog

jrochkind avatar Oct 16 '24 15:10 jrochkind

If we're going to remove the whitespace and borders around each facet, I think we also need to change the background color of the accordion headers (like IU + SHI do) to visually distinguish between the header and the facet values.

cbeer avatar Oct 22 '24 14:10 cbeer

Good suggestion @cbeer I've adjusted it as per this screenshot:

Screenshot 2024-10-22 at 1 14 55 PM

jcoyne avatar Oct 22 '24 17:10 jcoyne