blacklight icon indicating copy to clipboard operation
blacklight copied to clipboard

Published 20 hours ago • verified publisher icon projectblacklight

Pivot filter field

Open barmintor opened this issue 2 years ago • 2 comments

This is essentially implementing pivot fields as if they were a filter add-on, like range limits.

See also the conversation in #2464 , this permits use of pivot fields that are not individually configured as facets. I've included @dkinzer's tests from the other PR to make sure we have consensus about desired outcomes.

Fixes: #2463

barmintor avatar Apr 28 '22 20:04 barmintor

This PR does not remove the pivot behaviors fromBlacklight::SearchState::FilterField, even though they are not used in this branch.

barmintor avatar Apr 28 '22 20:04 barmintor

~~@barmintor I'm going to see if I can test this solution on our current app. But, the app is 7.x is this a solution that would work in the 7.x release?~~

Actually, since you are already including the specs in this update there's no need for me to test this in my current app. Plus I just re-read your comment on the related PR that this is a 8.x release change.

dkinzer avatar Aug 05 '22 13:08 dkinzer

As per Committer's Call, we're marking this ready for review. @dkinzer is taking on rebasing this so CI will pass, and has affirmed that this would solve his problem.

We feel like it would be good to backport this. Added to the committer's agenda.

tpendragon avatar Aug 17 '22 18:08 tpendragon

After rebase, there are some tests that are failing. So I'm putting this back to draft for now.

dkinzer avatar Aug 22 '22 17:08 dkinzer