arclight icon indicating copy to clipboard operation
arclight copied to clipboard

Continue primary testing with Blacklight 7

Open cbeer opened this issue 2 years ago • 3 comments

cbeer avatar Oct 17 '22 19:10 cbeer

It looks to me like this suffers from

Arclight Importmap asset generation
      append  config/importmap.rb
The file /home/runner/work/arclight/arclight/.internal_test_app/app/javascript/application.js does not appear to exist

https://github.com/projectblacklight/arclight/actions/runs/3267826382/jobs/5373500409#step:5:1143

which was fixed by https://github.com/projectblacklight/blacklight/pull/2834

jcoyne avatar Oct 17 '22 19:10 jcoyne

It doesn't look like Blacklight 7.31 fixed this. Any ideas, or should we revert the 8.x change until we can fix this?

cbeer avatar Oct 18 '22 16:10 cbeer

@cbeer no, I don't think we should revert. The problem now is:

 Arclight Importmap asset generation
      append  config/importmap.rb
File unchanged! The supplied flag value not found!  app/javascript/application.js

and the in-progress fix is in: https://github.com/projectblacklight/blacklight/pull/2838

jcoyne avatar Oct 18 '22 17:10 jcoyne