container-storage-setup icon indicating copy to clipboard operation
container-storage-setup copied to clipboard

Published 20 hours ago • verified publisher icon projectatomic

Fixes #282 use requiredby to make a hard dependency chain

Open Klaas- opened this issue 5 years ago • 3 comments

Fixes #282 use requiredby to make a hard dependency chain

Klaas- avatar Jun 28 '19 07:06 Klaas-

Can one of the admins verify this patch? I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

rh-atomic-bot avatar Jun 28 '19 07:06 rh-atomic-bot

@rhvgoyal PTAL As I recall we wanted to allow this to fail in order to allow Docker running with Devicemapper on loopback devices to work. I think containers-storage-setup would fail in that situation and cause Docker to use loopback devices. Now that we default to using Overlay, we could perhaps make the switch.

rhatdan avatar Jun 28 '19 12:06 rhatdan

So there is a situation where you expect the service to fail? Wouldn't it be better/easier to just not use the service ie when dm on loopback "systemctl disable docker-storage-setup"? or even fully remove the package and only install it when needed?

Klaas- avatar Jun 28 '19 12:06 Klaas-