container-storage-setup icon indicating copy to clipboard operation
container-storage-setup copied to clipboard

Can't handle devices that end in numbers, such as /dev/loop0

Open mvollmer opened this issue 9 years ago • 2 comments

When creating a partition on /dev/loop0, it will be called /dev/loop0p1, but docker-storage-setup will wait for /dev/loop01.

It is probably not important to support loop devices (although they are useful for testing), but other devices might follow a similar labeling scheme and would cause docker-storage-setup to fail in the same way.

mvollmer avatar May 13 '16 14:05 mvollmer

@rhvgoyal PTAL

rhatdan avatar May 14 '16 09:05 rhatdan

I also needed this change to get test_storage.sh (https://github.com/projectatomic/atomic/blob/master/tests/integration/test_storage.sh) pass successfully on my Fedora machine. It works for me modulo the question I had in the code.

giuseppe avatar May 27 '16 13:05 giuseppe