commissaire-mvp icon indicating copy to clipboard operation
commissaire-mvp copied to clipboard

Vagrantfile: Switch to use CentOS Atomic Host

Open cgwalters opened this issue 9 years ago • 6 comments

Just putting this out there for discussion. I didn't try switching the development box - if we wanted to do that it should be done via a "pet container". Given we already have the Dockerfile I think doing a docker build of that in the provisioner would work.

cgwalters avatar Aug 05 '16 16:08 cgwalters

Thanks @cgwalters! I'll give it a run and see how things go.

ashcrow avatar Aug 05 '16 17:08 ashcrow

@ashcrow a couple nits

  • sudo hostnamectl set-hostname fedora-cloud to sudo hostnamectl set-hostname atomic-node or something similar
  • remove # End etcd
  • should we add the atomic host upgrade back in or is it unnecessary?

cooktheryan avatar Aug 09 '16 17:08 cooktheryan

Updated for review comments. I didn't add atomic host upgrade - we should keep the vagrant boxes fresh enough.

cgwalters avatar Aug 11 '16 15:08 cgwalters

@cgwalters fair enough. The changes look good to me. @cooktheryan what do you think?

ashcrow avatar Aug 11 '16 18:08 ashcrow

Not clear to me why the IP addresses are changed, but the end-to-end tests under /features should be updated to match. (Also, this would be a good time to add a simple hostname lookup table for these tests so the IP addresses aren't spread all over.)

mbarnes avatar Aug 17 '16 11:08 mbarnes

:umbrella: The latest upstream changes (presumably #187) made this pull request unmergeable. Please resolve the merge conflicts.

rh-atomic-bot avatar Aug 17 '16 19:08 rh-atomic-bot