atomicapp icon indicating copy to clipboard operation
atomicapp copied to clipboard

Add support for authenticating via client certificate for Openshift

Open kadel opened this issue 9 years ago • 11 comments

fixes #533

TODO:

  • [ ] add docs
  • [x] add tests

kadel avatar Apr 18 '16 15:04 kadel

while the [WIP] text is in the name I assume you guys are still working on this. let me know when you want review.

dustymabe avatar Apr 19 '16 14:04 dustymabe

#dotests

kadel avatar Apr 20 '16 10:04 kadel

Is providing a cert+key in a single file (as mentioned here) a thing? If so are we supporting it with this work?

dustymabe avatar Apr 20 '16 20:04 dustymabe

Also, is there any chance we can bundle this bug in as part of this work: https://github.com/projectatomic/atomicapp/issues/529

dustymabe avatar Apr 20 '16 20:04 dustymabe

Great job guys.. Sorry about all the comments :( - we are really close though

dustymabe avatar Apr 20 '16 20:04 dustymabe

@kadel @dustymabe @surajssd

Shout... I forgot to mention that I already implemented this in kubebase.py in my PR...

See https://github.com/projectatomic/atomicapp/pull/712/files

Specifically, kubebase.py functions: _connection() and _certfile()...

cdrage avatar May 16 '16 14:05 cdrage

It also includes your issue of base64 encoding (converts files to base64, etc.) as well as cert requests when specifying a certificate.

Originally, i was implementing this for the kubernetes api, but because of how similar both the openshift + kubernetes api http implementations are, the cert passing works for both.

cdrage avatar May 16 '16 14:05 cdrage

@cdrage so you're saying that #533 is handled by #712?

dustymabe avatar May 20 '16 14:05 dustymabe

@dustymabe yes sir

cdrage avatar May 20 '16 15:05 cdrage

@dustymabe @cdrage is it time to close this PR?

surajssd avatar May 21 '16 05:05 surajssd

@cdrage since work around this is being done in #743, let's close this? WDYT?

concaf avatar Jul 21 '16 18:07 concaf