atomicapp icon indicating copy to clipboard operation
atomicapp copied to clipboard

provider in answers.conf defaults to "kubernetes" regardless of what's supported in Nulecule file

Open jberkus opened this issue 9 years ago • 9 comments

The way it is now:

The "provider" in generated answers.conf always defaults to "kubernetes" regardless of what's supported in the Nulecule file.

The way it should be:

If only one provider is specified in the Nulecule file under artifacts, then that should be the default. If multiple providers are specified but not Kubernetes, it should be None.

jberkus avatar Mar 03 '16 23:03 jberkus

BTW, when combined with #562 this is particularly confusing to the user.

jberkus avatar Mar 03 '16 23:03 jberkus

There is some history behind this: https://github.com/projectatomic/atomicapp/issues/380 and then https://github.com/projectatomic/atomicapp/issues/515

We opted to go with the fact that the application owner can set a default provider if they like within the parameters:

params:
    - name: provider
      description: The provider that is used to deploy the application
      default: openshift

dustymabe avatar Mar 04 '16 04:03 dustymabe

@dustymabe that you can set the provider in the nulecule file isn't well-documented and doesn't show up in any of our examples. So like other new users I'd have no reason to know that.

Where would be an appropriate place to doc it?

jberkus avatar Mar 04 '16 18:03 jberkus

@jberkus I wonder if we shouldn't start a FAQ and we could document this there until a more appropriate place emerges?

dustymabe avatar Mar 09 '16 03:03 dustymabe

@dustymabe what do you say about the #606 in regards with this issue?

surajssd avatar Mar 09 '16 03:03 surajssd

@surajssd #606 definitely helps but I think we should add docs like @jberkus suggests and also update our examples to set a default provider in them (in the nulecule-library). If @jberkus thinks that is reasonable we will open an issue for that.

dustymabe avatar Mar 09 '16 04:03 dustymabe

@dustymabe a FAQ might be a good idea.

jberkus avatar Mar 09 '16 04:03 jberkus

@jberkus FAQ sounds good

surajssd avatar Mar 09 '16 15:03 surajssd

"Provider not specified" message showing up now, so that's good.

jberkus avatar Apr 25 '16 22:04 jberkus