atomicapp icon indicating copy to clipboard operation
atomicapp copied to clipboard

Use docker api rather than docker binary

Open dustymabe opened this issue 10 years ago • 9 comments

part of #407

will allow us to stop embedding docker binary inside our containers.

dustymabe avatar Dec 08 '15 16:12 dustymabe

@rtnpro I would really want to help on this and #407 if you need any :)

concaf avatar Feb 23 '16 05:02 concaf

@containscafeine @rtnpro

I was looking at this before and finding out the best possible way to convert docker run / cli commands to it's respective daemon API call. Unfortunately I was unable to find such way.

May be out of the scope of atomicapp, but starting a Python library that actually converts for example: docker run blahblah -v foo:bar to the http api call would be awesome.

I tried searching for such a library but was unable to :(

cdrage avatar Feb 23 '16 19:02 cdrage

@cdrage +1, sounds cool. And when we run the docker daemon in foreground, then with each CLI command, we can see the corresponding API call, so maybe we can use that. But that's in Go.

But in this case, will we not be using one of these?

The last time I checked, python only maintained docker-py, but now I can also see them working on engine-api in Go!

concaf avatar Feb 23 '16 20:02 concaf

I think docker-py is what I thought we would end up using. It is what Ansible uses to run docker containers. If there is a feature missing that we need then we should possibly add it or understand why it doesn't make sense to implement.

dustymabe avatar Feb 24 '16 03:02 dustymabe

@dustymabe @cdrage @rtnpro has some work been done in atomicapp using docker-py or has someone started working on it?

On Wed, Feb 24, 2016, 9:16 AM Dusty Mabe [email protected] wrote:

I think docker-py is what I thought we would end up using. It is what Ansible uses to run docker containers. If there is a feature missing that we need then we should possibly add it or understand why it doesn't make sense to implement.

— Reply to this email directly or view it on GitHub https://github.com/projectatomic/atomicapp/issues/445#issuecomment-188049224 .

concaf avatar Feb 24 '16 04:02 concaf

@containscafeine not yet! you'll be the first :)

cdrage avatar Feb 24 '16 14:02 cdrage

@cdrage PRs incoming :)

concaf avatar Feb 24 '16 14:02 concaf

@containscafeine any progress on this?

I opened up a feature request upstream that might be useful in this endeavor. https://github.com/docker/docker-py/issues/1031

dustymabe avatar Apr 07 '16 20:04 dustymabe

@dustymabe nothing yet, but on it now!

concaf avatar Apr 07 '16 23:04 concaf