projectatomic
Refactor Nulecule params
Refactor Nulecule/atomicapp params to support developing nested Nulecule applications easy. This work is to fix the issues discussed in https://github.com/projectatomic/nulecule/issues/187
Fixes #423.
@kanarip @dustymabe @vpavlin @cdrage You can try out this code with https://github.com/projectatomic/nulecule-library/pull/30
@rtnpro a lot of tests fail, we'll have to have compatibility from putting params both under graph and params, unless our spec changes in the future
I have not looked at the code at all but have looked at the POC code in https://github.com/projectatomic/nulecule-library/pull/30. This looks interesting and I am going through and going to try to convert my etherpad app to do the same thing and see what all I need to change.
@cdrage. Do you mind looking at this in detail and also consider the work you did for xpathing when you review? Start with https://github.com/projectatomic/nulecule-library/pull/30 and then we can both look at the code in this PR.
One thing I noticed when playing around with this is that only parts of the config are getting passed to the provider. An example is that if I put 'providerconfig' into the answers.conf file it does not make it into the provider code. The logger.debug("Given config: %s", self.config) from the kubernetes provider is a good one to look at to see what is getting passed.
@vpavlin @dustymabe @cdrage @kadel @goern
So, I updated the POC for refactoring params in Nulecule spec here: https://github.com/rtnpro/nulecule-library/commit/4c9ee7b0dfaed9a14a4d19ad05298d3db14d154e
It allows:
Cross referencing params
This allows referencing params definition across sibling components in a Nulecule. It fixes duplicate param problem in answers or config data.
Config mapping
It allows channelize config from current Nulecule to its external Nulecule children, or, local component according to their needs. This allows, optionally, in controlling access to config data to external Nulecule apps.
The end result will be a cleaner and understandable answers file, where users enter param values only for the immediate Nulecule they are consuming.
However, this will not take the freedom of overriding config data for a Nulecule component at any level in the Nulecule tree by adding a section for it in answers file, just like the way it works now.
@rtnpro I looked at your sentry example and it seems like there is a lot of mixing of ideas in there, which is probably a mistake. Do you mind adding your new proposal to https://gist.github.com/rtnpro/17add2ab248ac34a7687 so it can clearly be evaluated?
@dustymabe @cdrage @surajssd @containscafeine Let's resume discussions on this and reach a decision ASAP.
https://gist.github.com/rtnpro/17add2ab248ac34a7687#file-nulecule_with_param_cross_ref_and__optional_mapping-md