projectatomic
Run yamllint as a part of the PR tester
In #297 and #299 yes/no values should be quoted or true/false should be used instead. These issues were identified by yamllint.
Lets run yamllint as part of the PR testing so ansible playbooks/roles are compliant.
That makes sense to me. I'd even say let's mark it as required and hook up Homu to this repo? Even though it's only a linter, hooking up Homu still gets you e.g. auto-squashing, delegation, etc..
@mike-nguyen any reservations about using Homu? Seems like we are overdue.
Not at all. We are like barbarians pushing this squash and merge button.
I just ran yamllint with the defaults against the tests directory and there is a mountain of warnings/errors to address. So before we turn on the linter, let's make sure we have the existing violations sorted out.
#302 Addressed many of the yamllint errors but there were some lines that couldn't be easily shortened to the 80 character limit. We could setup our own yamllint rules for make exceptions for line length.
Probably need something like this in a yamllint.cfg file:
---
extends: default
rules:
linelength: 90
I found this to work. Noting for future reference.
---
extends: default
rules:
line-length:
max: 90