atomic-host-tests icon indicating copy to clipboard operation
atomic-host-tests copied to clipboard

cleanup and consolidate roles

Open miabbott opened this issue 8 years ago • 2 comments

I was stepping (via --step) through the improved-sanity-tests and examining the test itself by hand and realized that we have more than a few instances of duplication in our roles directory.

We should attempt to identify roles that can be combined and made more flexible via passed in parameters.

Things that jump right out:

  • docker_build_httpd & docker_build_tag_push
  • docker_pull_base_image & docker_pull_run_remove
  • docker_rm_httpd_conainer could be generalized
  • maybe some of the verify missing/present roles

miabbott avatar May 10 '17 20:05 miabbott

As part of this work, we should try to structure the roles directory using sub-dirs that correspond to major pieces of functionality. For example:

roles/
├── atomic
│   ├── containers
│   ├── images
│   ├── install
│   ├── run
│   └── tasks
├── docker
│   ├── build
│   ├── rm
│   ├── rmi
│   ├── run
│   └── tasks
├── ostree
│   ├── admin
│   ├── log
│   ├── pull
│   ├── remote
│   └── tasks
└── rpm-ostree
    ├── compose
    ├── deploy
    ├── install
    ├── tasks
    └── upgrade

There could be even more sub-dirs under each one of those, too.

miabbott avatar May 17 '17 18:05 miabbott