atomic-host-tests
atomic-host-tests copied to clipboard
cleanup and consolidate roles
I was stepping (via --step) through the improved-sanity-tests and examining the test itself by hand and realized that we have more than a few instances of duplication in our roles directory.
We should attempt to identify roles that can be combined and made more flexible via passed in parameters.
Things that jump right out:
docker_build_httpd&docker_build_tag_pushdocker_pull_base_image&docker_pull_run_removedocker_rm_httpd_conainercould be generalized- maybe some of the verify missing/present roles
As part of this work, we should try to structure the roles directory using sub-dirs that correspond to major pieces of functionality. For example:
roles/
├── atomic
│ ├── containers
│ ├── images
│ ├── install
│ ├── run
│ └── tasks
├── docker
│ ├── build
│ ├── rm
│ ├── rmi
│ ├── run
│ └── tasks
├── ostree
│ ├── admin
│ ├── log
│ ├── pull
│ ├── remote
│ └── tasks
└── rpm-ostree
├── compose
├── deploy
├── install
├── tasks
└── upgrade
There could be even more sub-dirs under each one of those, too.