projectm icon indicating copy to clipboard operation
projectm copied to clipboard

CHECK_GL_ERROR additions

Open revmischa opened this issue 1 year ago • 1 comments

Maybe helpful for debugging bad GL calls

revmischa avatar May 12 '24 21:05 revmischa

Before merging and reworking this code again, I'd suggest leaving it in a branch to fix the GStreamer issues, and then implement a proper debugging API via this issue here:

https://github.com/projectM-visualizer/projectm/issues/732

Thst'd save us from reworking any existing code and use a proper debug class/functionality so an outside app can properly log any errors.

kblaschke avatar May 13 '24 08:05 kblaschke

I guess all the GL_INVALID_ENUM errors seen were due to that uninitialized framebuffer texture being used before the first frame was drawn. This is fixed in PRs #826 and #827.

May I close this PR and postpone proper GL error checking/logging to the implementation of issue #732?

kblaschke avatar Jul 12 '24 12:07 kblaschke

Sure thing

revmischa avatar Jul 12 '24 15:07 revmischa