zot icon indicating copy to clipboard operation
zot copied to clipboard

Added imagestore regulator to limit the maximum concurrent go routines,

Open eusebiu-constantin-petu-dbk opened this issue 2 years ago • 3 comments

in order the avoid 'maximum open files' error

Signed-off-by: Petu Eusebiu [email protected]

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #462 (500cd43) into main (10f0e6c) will increase coverage by 0.08%. The diff coverage is 88.82%.

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   83.80%   83.88%   +0.08%     
==========================================
  Files          49       50       +1     
  Lines       10210    10385     +175     
==========================================
+ Hits         8556     8711     +155     
- Misses       1294     1312      +18     
- Partials      360      362       +2     
Impacted Files Coverage Δ
pkg/api/config/config.go 79.31% <ø> (ø)
pkg/storage/storage_fs.go 78.65% <68.42%> (-0.18%) :arrow_down:
pkg/storage/regulator.go 90.96% <90.96%> (ø)
pkg/api/controller.go 91.10% <100.00%> (+0.07%) :arrow_up:
pkg/extensions/sync/utils.go 79.64% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Mar 16 '22 15:03 codecov[bot]

related issue: #359

We may not need this after HTTP ratelimiting support and background tasks infra.

rchincha avatar Aug 20 '22 22:08 rchincha

This PR is too old to maintain. Let's open a new one if needed.

andaaron avatar Aug 27 '23 07:08 andaaron