project-zot
feat: redis dedup backend
hi ! im attempting to implement #2004
im not done yet (i need to add the configuration switch case and look at other things), but i thought i would push up some progress, and maybe if this is an awful idea or i am doing something very bad code wise i should know.
it passes tests using an embedded redis, so that is good
What does this PR do / Why do we need it:
adds a redis backend for the dedup cache
Testing done on this change:
i've copied the test from bolt and ran it with embedded redis.
Automation added to e2e:
not any. should i add a test that spins up redis docker image?
Will this break upgrades or downgrades?
it will break downgrades if the user downgrades to a version that no longer supports redis and they are using redis
Does this PR introduce any user-facing change?:
adds redis as backend for dedup cache
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
I would love to see Redis support added. Are you still working on this?
hi yes, I plan to see this pr to completion
@elee1766 Thanks for all the work you are doing ...
Just FYI,
https://github.com/project-zot/zot/issues/1395 https://github.com/project-zot/zot/pull/2041
@elee1766 There is a user requirement for this feature. https://github.com/project-zot/zot/discussions/2365
We can take over this PR.
Is this still being worked on?
Hi @EStork09, I picked this up and continued working on the implementation, in https://github.com/project-zot/zot/pull/2865.
https://github.com/project-zot/zot/pull/2865 has been merged, let's close this.