oak icon indicating copy to clipboard operation
oak copied to clipboard

Move the `LogError` trait from `oak_utils` to `oak_functions_logger` crate

Open conradgrobler opened this issue 2 years ago • 1 comments

The oak_utils crate contains code generation utilities, so it intended to be used as a build-time-only depenndency. The LogError trait is used at runtime so should be moved to another crate so that dependencies on oak_utils can become build dependencies again.

The oak_functions_logger crate is probably the most appropriate, as it already contains a logging-related trait.

conradgrobler avatar Mar 08 '22 08:03 conradgrobler

It might also be useful to have a unified ExtensionLogger trait, rather than just an ErrorLogger that can be implemented by all extensions, providing log_error, log_warn, log_info and log_debug

conradgrobler avatar Mar 08 '22 12:03 conradgrobler

This trait no longer exists and the oak_utils crate has been renamed to oak_grpc_utils and now only contains GRPC and proto code generation logic.

conradgrobler avatar Nov 25 '22 13:11 conradgrobler