libprimis
libprimis copied to clipboard
Comment or remove variadic macros in `texture.h`
texture.h
defines the LOCALPARAMI
and LOCALPARAMF
macros as well as GLOBALPARAMI
GLOBALPARAMF
, SETSHADER
, and SETVARIANT
, all of which are variadic macros (can take arbitrary numbers of arguments). This is undesirable as:
- ~~C++03 doesn't technically support variadic macros (though C++11 and above does)~~ (we use C++17 now)
- Macros are ugly and macros that take arbitrary numbers of arguments and occupy the global namespace even more so.
If they are absolutely irreplaceable, comments should be left nearby affirming why this is so.