npwd icon indicating copy to clipboard operation
npwd copied to clipboard

Refactor In-Phone Notifications

Open TasoOneAsia opened this issue 3 years ago • 8 comments

Pull Request Description Notification system could use a refactor to enhance its UX. Here are some of the new proposed specifications.

Feature Specs:

  • Should be animated with Grow transitions
  • API should be declarative, the current one feels extremely imperative and delicate.
  • Bridge to the SoundProvider should not have any transitive dependencies that cause unexpected behavior
  • Expose notification layer to game scripts
  • Basic action system embedded in notifications

Tasks Progress

  • [x] Design presentation layer (animations, design)
  • [x] Handle animations when phone is closed.
  • [ ] Create fully fleshed API for notification system.
  • [ ] Migrate apps from old notification system to new one.
  • [ ] Add sound support
  • [x] Expose phone notification export API (maybe?)
  • [ ] Remove legacy notification system

Pull Request Checklist:

  • [x] Have you followed the guidelines in our Contributing document and Code of Conduct?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you built and tested NPWD in-game after the relevant change?

TasoOneAsia avatar Nov 23 '21 03:11 TasoOneAsia

Here is a short video showcasing new design and animations.

https://streamable.com/350u1x

TasoOneAsia avatar Nov 23 '21 03:11 TasoOneAsia

@RockySouthpaw @itschip. Can you guys take a look above and let me know what you guys think? Open to further feedback as well.

TasoOneAsia avatar Nov 23 '21 03:11 TasoOneAsia

Expose notification layer to game scripts

this would be pogs for any future app implementation. Should also do it maybe to alerts but idk tbh. I don’t see many uses for alerts outside of error and success within current apps (though an inform one would be nice for twitter registration)

RockySouthpaw avatar Nov 23 '21 03:11 RockySouthpaw

this would be pogs for any future app implementation.

I've actually exposed the initial queueNotification method to game scripts. Maybe this should be something exposed as an npwd export as well?

TasoOneAsia avatar Nov 23 '21 03:11 TasoOneAsia

Be sure to also to not use NUI to play any sounds Kappa

RockySouthpaw avatar Nov 23 '21 03:11 RockySouthpaw

this would be pogs for any future app implementation.

I've actually exposed the initial queueNotification method to game scripts. Maybe this should be something exposed as an npwd export as well?

yea an export would be ideal and easy to use for users as well. Easier to provide documentation too.

RockySouthpaw avatar Nov 23 '21 05:11 RockySouthpaw

Now pending me testing in-game for migration work.

TasoOneAsia avatar Nov 29 '21 01:11 TasoOneAsia

Could entering and leaving animations use position, not height, so they will slide in and slide out, instead of "scan" effect?

MJRamon avatar Feb 08 '22 02:02 MJRamon