copacetic icon indicating copy to clipboard operation
copacetic copied to clipboard

feat: Add guardrails for parsing OS version

Open h4l0gen opened this issue 9 months ago • 2 comments

adding guardrails for parsing OS version as per discussion

Closes #438

h4l0gen avatar May 11 '24 05:05 h4l0gen

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.92%. Comparing base (2602d59) to head (9383ae4). Report is 136 commits behind head on main.

Files Patch % Lines
pkg/patch/patch.go 76.47% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   32.51%   33.92%   +1.41%     
==========================================
  Files          17       18       +1     
  Lines        1621     1518     -103     
==========================================
- Hits          527      515      -12     
+ Misses       1062      970      -92     
- Partials       32       33       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 11 '24 05:05 codecov[bot]

Hey sorry, as per this we need to run golangci-lint too, i will run it and make required changes if any.

h4l0gen avatar May 11 '24 05:05 h4l0gen

closing due to #736

ashnamehrotra avatar Aug 22 '24 18:08 ashnamehrotra