multi-cluster-app-dispatcher icon indicating copy to clipboard operation
multi-cluster-app-dispatcher copied to clipboard

[Error handling] Evaluate MCAD code base for better error handling

Open asm582 opened this issue 1 year ago • 2 comments

WHY

This change is needed to retry or appropriately update etcd

WHAT

Review code base for error handling scenarios

HOW

Make relevant code changes and print appropriate error strings.

TESTS

Write additional tests for error handling

DONE

Increase in test cases that support error handling use case.

asm582 avatar Aug 28 '23 15:08 asm582

Hi @asm582, just a question about this issue which I have started working on. Is it appropriate to update some functions to return errors, so that we can catch the errors when the functions are called or do we just want to add logging of errors for other function calls inside the functions? I just don't want to many any changes that could effect others using MCAD if that's not what is required. Please let me know what you think. Thank you.

Fiona-Waters avatar Oct 27 '23 15:10 Fiona-Waters

Hi @Fiona-Waters , I think it's a good idea to start logging errors for now and then we can design later how we can gracefully handle errors.

asm582 avatar Oct 27 '23 15:10 asm582