zap icon indicating copy to clipboard operation
zap copied to clipboard

Need a way to mark clusters as provisional

Open bzbarsky-apple opened this issue 2 years ago • 5 comments

We have a set of clusters that are present in our XML but should be marked provisional, so some aspects of codegen can skip over them and we don't incorrectly ship provisional features.

We could probably hardcode the list somewhere in Matter, but it might be a good idea to have this information actually available in the ZAP database....

bzbarsky-apple avatar Aug 04 '22 14:08 bzbarsky-apple

@tecimovic @brdandu

bzbarsky-apple avatar Aug 04 '22 15:08 bzbarsky-apple

We have a set of clusters that are present in our XML but should be marked provisional, so some aspects of codegen can skip over them and we don't incorrectly ship provisional features.

We could probably hardcode the list somewhere in Matter, but it might be a good idea to have this information actually available in the ZAP database....

Trying to get some clarity on this. What is the use case where having a cluster as provisional is different from disabling the cluster?

brdandu avatar Sep 09 '22 17:09 brdandu

@brdandu "disabling" in what sense?

Note that there are things that are generated by ZAP (like APIs) that don't have an application definition in the .zap file in any sense; they just use whatever the database knows about. And those are what would need to know about provisional things to filter them out.

bzbarsky-apple avatar Sep 10 '22 05:09 bzbarsky-apple

@brdandu "disabling" in what sense?

Note that there are things that are generated by ZAP (like APIs) that don't have an application definition in the .zap file in any sense; they just use whatever the database knows about. And those are what would need to know about provisional things to filter them out.

@bzbarsky-apple could you point me to the spec on this to get more understanding on how this will be added to the xml, do we need further UI changes on this, etc.

brdandu avatar Jan 30 '23 16:01 brdandu

could you point me to the spec on this

See "1.8.4. Provisional" in the main Matter spec and "7.3.2. Provisional".

more understanding on how this will be added to the xml

The spec does not really talk about the XML. But to the extent that we want the XML to be a faithful reflection of the spec, we need to either exclude provisional things from the XML (which has not been done up to now) or mark them as provisional in the XML.

bzbarsky-apple avatar Jan 30 '23 22:01 bzbarsky-apple