zap icon indicating copy to clipboard operation
zap copied to clipboard

Incorrect warnings about missing clusters for Air Quality?

Open olavt opened this issue 2 years ago • 2 comments

Issue is decribed here:

https://community.silabs.com/s/question/0D5Vm0000066HePKAU/incorrect-zap-tool-warnings?language=en_US

olavt avatar Mar 22 '24 09:03 olavt

@brdandu would know best about this

paulr34 avatar Jun 14 '24 13:06 paulr34

So the warnings are actually coming from the Matter XML. Whatever is the default state of the device type. In this case it is

<deviceType> <name>MA-air-quality-sensor</name> <domain>CHIP</domain> <typeName>Matter Air Quality Sensor</typeName> <profileId editable="false">0x0103</profileId> <deviceId editable="false">0x002C</deviceId> <class>Simple</class> <scope>Endpoint</scope> <clusters lockOthers="true"> <include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true"></include> <include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true"> <requireAttribute>IDENTIFY_TIME</requireAttribute> <requireAttribute>IDENTIFY_TYPE</requireAttribute> <requireCommand>Identify</requireCommand> </include> <include cluster="Air Quality" client="false" server="true" clientLocked="true" serverLocked="true"></include> <include cluster="Temperature Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Relative Humidity Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Carbon Monoxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Carbon Dioxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Nitrogen Dioxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Ozone Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Formaldehyde Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM1 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM2.5 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM10 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Radon Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Total Volatile Organic Compounds Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> </clusters> </deviceType>

which includes Radon Concentration Measurement server even though it may not be mandatory. ZAP wants to assist the user about what is coming from the xml. We can look into improving the warning system to also say Radon Concentration Measurement server cluster is required by default but not mandatory if that improves the user experience.

brdandu avatar Jun 14 '24 14:06 brdandu