connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

Evaluate whether UnsolicitedMessageHandler::Matches can test IsInUse() without codesize impact

Open bzbarsky-apple opened this issue 3 years ago • 3 comments

Problem

After https://github.com/project-chip/connectedhomeip/pull/5606, UnsolicitedMessageHandler::Matches needs to be called only when IsInUse() is known to be true. We could add an IsInUse() test inside Matches(), but need to check codesize impact. Which is hard right now because that code is not actually used in anything we measure codesize for.

Proposed Solution

Wait for https://github.com/project-chip/connectedhomeip/pull/5095 or equivalent to land, then do the measuring.

bzbarsky-apple avatar Mar 25 '21 14:03 bzbarsky-apple

Or #5627

bzbarsky-apple avatar Mar 29 '21 15:03 bzbarsky-apple

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 25 '22 04:07 stale[bot]

This stale issue has been automatically closed. Thank you for your contributions.

stale[bot] avatar Oct 18 '22 19:10 stale[bot]

Measured this on esp32 just now, and it's a slight (4 bytes) codesize hit. Probably not worth it.

bzbarsky-apple avatar Mar 29 '23 22:03 bzbarsky-apple