We don't seem to have any unit tests for message MAC (tag)

[bzbarsky-apple]

Problem

I just tried changing the function signatures of MessageAuthenticationCode::Encode and MessageAuthenticationCode::Decode, and all our tests still compiled, which means they never call those functions directly.

Proposed Solution

We should probably add some test coverage, unless is covered in some way that was non-obvious to me.

@pan-apple

[pan-apple]

void SecureChannelDecryptTest(nlTestSuite * inSuite, void * inContext) tests the MAC tag to certain extent (i.e. if MAC tag is incorrect, the test will fail). It might be worth adding a standalone unit tests for MessageAuthenticationCode encode/decode. That test will mostly be testing the current memcpy of tag value in the packet buffer.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.