connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

Various logging length constants are unused

Open bzbarsky-apple opened this issue 4 years ago • 2 comments

Problem

In CHIPLogging.h we have the following constants that as far as I can tell are completely unused:

static constexpr uint16_t kMaxSeparatorLen   = 2;
static constexpr uint16_t kMaxTrailerLen     = 2;
static constexpr uint16_t kMaxMessagePadding = (chip::Logging::kMaxPrefixLen + chip::Logging::kMaxModuleNameLen +
                                                chip::Logging::kMaxSeparatorLen + chip::Logging::kMaxTrailerLen);

There's also kMaxPrefixLen which is used, but incorrectly. See #4729

Proposed Solution

Remove unused/misused constants.

bzbarsky-apple avatar Feb 08 '21 18:02 bzbarsky-apple

See also https://github.com/project-chip/connectedhomeip/pull/4627 which renamed these constants but did not really change their used-ness.

bzbarsky-apple avatar Feb 08 '21 18:02 bzbarsky-apple

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 16 '22 13:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 22 '23 22:03 stale[bot]

The unused constants are gone now.

bzbarsky-apple avatar Mar 23 '23 16:03 bzbarsky-apple