connectedhomeip
connectedhomeip copied to clipboard
Various logging length constants are unused
Problem
In CHIPLogging.h we have the following constants that as far as I can tell are completely unused:
static constexpr uint16_t kMaxSeparatorLen = 2;
static constexpr uint16_t kMaxTrailerLen = 2;
static constexpr uint16_t kMaxMessagePadding = (chip::Logging::kMaxPrefixLen + chip::Logging::kMaxModuleNameLen +
chip::Logging::kMaxSeparatorLen + chip::Logging::kMaxTrailerLen);
There's also kMaxPrefixLen
which is used, but incorrectly. See #4729
Proposed Solution
Remove unused/misused constants.
See also https://github.com/project-chip/connectedhomeip/pull/4627 which renamed these constants but did not really change their used-ness.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
The unused constants are gone now.