connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard
verified publisher icon project-chip

[HVAC] Thermostat - Fix incorrect deadband default, update test script

Open hasty opened this issue 2 months ago • 5 comments

Summary

In the 1.4.2 release, we fixed an error in the default values of the thermostat setpoints: the default values for heating and cooling setpoints violated the default value of the deadband. This was corrected by reducing the default value of the deadband from 2.5C to 2.0C.

This PR updates the example thermostat cluster code to use 2.0C as its default value, and fixes a shortcoming in the associated test: previously, the test would change the deadband to its extreme values: 0C and 12.7C, leaving it with an exceptionally large deadband. The spec indicates that changing this value should not actually have any effect, and production thermostats follow this, but the example server actually takes the values.

We'll be fixing this in a future PR, but for now this updates the script to set the deadband back to its original value after testing the extremes.

Related issues

Testing

Tested locally with TC_TSTAT_2_2.py

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the code readable:

  • [X] PR title is descriptive
  • [X] Apply the “When in Rome…” rule (coding style)
  • [X] PR size is short
  • [X] Try to avoid "squashing" and "force-update" in commit history
  • [X] CI time didn't increase

hasty avatar Nov 04 '25 22:11 hasty

PR #41772: Size comparison from 1e415cff9e9fa5413086fe82794fafffd31e8855 to b8451ffcbb922847452cf4ead63cbb6aeebdf03c

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 1e415cff b8451ffc change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106156 1106156 0 0.0
RAM 178882 178882 0 0.0
bl702 lighting-app bl702+eth FLASH 661308 661308 0 0.0
RAM 134969 134969 0 0.0
bl702+wifi FLASH 836844 836844 0 0.0
RAM 124405 124405 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070388 1070388 0 0.0
RAM 117277 117277 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 899836 899836 0 0.0
RAM 105540 105540 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983150 983150 0 0.0
RAM 109756 109756 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770516 770516 0 0.0
RAM 103304 103304 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 782360 782360 0 0.0
RAM 108472 108472 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728308 728308 0 0.0
RAM 97364 97364 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 712784 712784 0 0.0
RAM 97580 97580 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554826 554826 0 0.0
RAM 205744 205744 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587706 587706 0 0.0
RAM 205840 205840 0 0.0
efr32 lock-app BRD4187C FLASH 963200 963200 0 0.0
RAM 123512 123512 0 0.0
BRD4338a FLASH 757384 757384 0 0.0
RAM 254152 254152 0 0.0
window-app BRD4187C FLASH 1058436 1058436 0 0.0
RAM 119740 119740 0 0.0
esp32 all-clusters-app c3devkit DRAM 102524 102524 0 0.0
FLASH 1836510 1836510 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 933176 933176 0 0.0
RAM 161317 161317 0 0.0
nxp contact mcxw71+release FLASH 692104 692104 0 0.0
RAM 61496 61496 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1677748 1677748 0 0.0
RAM 213908 213908 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1594140 1594140 0 0.0
RAM 211116 211116 0 0.0
light cy8ckit_062s2_43012 FLASH 1460380 1460380 0 0.0
RAM 197736 197736 0 0.0
lock cy8ckit_062s2_43012 FLASH 1493060 1493060 0 0.0
RAM 225448 225448 0 0.0
qpg lighting-app qpg6200+debug FLASH 837480 837480 0 0.0
RAM 127716 127716 0 0.0
lock-app qpg6200+debug FLASH 774324 774324 0 0.0
RAM 118692 118692 0 0.0
realtek light-switch-app rtl8777g FLASH 706632 706632 0 0.0
RAM 106912 106912 0 0.0
lighting-app rtl8777g FLASH 757592 757592 0 0.0
RAM 127244 127244 0 0.0
stm32 light STM32WB5MM-DK FLASH 469972 469972 0 0.0
RAM 141312 141312 0 0.0
telink bridge-app tl7218x FLASH 710514 710514 0 0.0
RAM 90544 90544 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 796990 796990 0 0.0
RAM 41008 41008 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 788190 788190 0 0.0
RAM 93644 93644 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715192 715192 0 0.0
RAM 51852 51852 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748488 748488 0 0.0
RAM 70900 70900 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725344 725344 0 0.0
RAM 34600 34600 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602622 602622 0 0.0
RAM 108912 108912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820794 820798 4 0.0
RAM 92040 92040 0 0.0

github-actions[bot] avatar Nov 04 '25 22:11 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 25 '25 15:11 CLAassistant

PR #41772: Size comparison from efdf99d3a6e4a7d0170db5a09a47210775eb96ec to a2cefe7e009684e6773f8e29376a1d35b6a30c6a

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section efdf99d3 a2cefe7e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1105860 1105860 0 0.0
RAM 178954 178954 0 0.0
bl702 lighting-app bl702+eth FLASH 660680 660680 0 0.0
RAM 135025 135025 0 0.0
bl702+wifi FLASH 836530 836530 0 0.0
RAM 124485 124485 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070174 1070174 0 0.0
RAM 117341 117341 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 902384 902384 0 0.0
RAM 105932 105932 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 982920 982920 0 0.0
RAM 109844 109844 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770776 770776 0 0.0
RAM 103392 103392 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 783588 783588 0 0.0
RAM 108712 108712 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728616 728616 0 0.0
RAM 97452 97452 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713064 713064 0 0.0
RAM 97660 97660 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554588 554588 0 0.0
RAM 205472 205472 0 0.0
lock CC3235SF_LAUNCHXL FLASH 588528 588528 0 0.0
RAM 205720 205720 0 0.0
efr32 lock-app BRD4187C FLASH 964748 964748 0 0.0
RAM 123776 123776 0 0.0
BRD4338a FLASH 759072 759072 0 0.0
RAM 254388 254388 0 0.0
window-app BRD4187C FLASH 1059888 1059888 0 0.0
RAM 120004 120004 0 0.0
esp32 all-clusters-app c3devkit DRAM 102812 102812 0 0.0
FLASH 1830854 1830854 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 936264 936264 0 0.0
RAM 161724 161724 0 0.0
nxp contact mcxw71+release FLASH 695104 695104 0 0.0
RAM 61744 61744 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1680956 1680956 0 0.0
RAM 214188 214188 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1595436 1595436 0 0.0
RAM 211364 211364 0 0.0
light cy8ckit_062s2_43012 FLASH 1460060 1460060 0 0.0
RAM 197800 197800 0 0.0
lock cy8ckit_062s2_43012 FLASH 1494004 1494004 0 0.0
RAM 225672 225672 0 0.0
qpg lighting-app qpg6200+debug FLASH 838248 838248 0 0.0
RAM 127984 127984 0 0.0
lock-app qpg6200+debug FLASH 775984 775984 0 0.0
RAM 118920 118920 0 0.0
realtek light-switch-app rtl8777g FLASH 708688 708688 0 0.0
RAM 107188 107188 0 0.0
lighting-app rtl8777g FLASH 757392 757392 0 0.0
RAM 127320 127320 0 0.0
stm32 light STM32WB5MM-DK FLASH 470244 470244 0 0.0
RAM 141392 141392 0 0.0
telink bridge-app tl7218x FLASH 703898 703898 0 0.0
RAM 90760 90760 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 790246 790246 0 0.0
RAM 41176 41176 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 781558 781558 0 0.0
RAM 93860 93860 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710042 710042 0 0.0
RAM 52232 52232 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 745874 745874 0 0.0
RAM 71256 71256 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 720554 720554 0 0.0
RAM 34956 34956 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602362 602362 0 0.0
RAM 117736 117736 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815066 815070 4 0.0
RAM 92248 92248 0 0.0

github-actions[bot] avatar Dec 08 '25 14:12 github-actions[bot]

PR #41772: Size comparison from 19384da4fd725ff2d33d2aec6dea528c5a97e0d5 to 99598d8cf545895412f9481147450a5188929bb3

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 19384da4 99598d8c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106542 1106542 0 0.0
RAM 178970 178970 0 0.0
bl702 lighting-app bl702+eth FLASH 661368 661368 0 0.0
RAM 135041 135041 0 0.0
bl702+wifi FLASH 837212 837212 0 0.0
RAM 124501 124501 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070858 1070858 0 0.0
RAM 117357 117357 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 903068 903068 0 0.0
RAM 105948 105948 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983604 983604 0 0.0
RAM 109860 109860 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 771384 771384 0 0.0
RAM 103400 103400 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 784188 784188 0 0.0
RAM 108728 108728 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 729192 729192 0 0.0
RAM 97468 97468 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713688 713688 0 0.0
RAM 97676 97676 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 555176 555176 0 0.0
RAM 205480 205480 0 0.0
lock CC3235SF_LAUNCHXL FLASH 589108 589108 0 0.0
RAM 205736 205736 0 0.0
efr32 lock-app BRD4187C FLASH 965388 965388 0 0.0
RAM 123808 123808 0 0.0
BRD4338a FLASH 759944 759944 0 0.0
RAM 254404 254404 0 0.0
window-app BRD4187C FLASH 1060744 1060744 0 0.0
RAM 120004 120004 0 0.0
esp32 all-clusters-app c3devkit DRAM 102820 102820 0 0.0
FLASH 1831564 1831564 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 936888 936888 0 0.0
RAM 161736 161736 0 0.0
nxp contact mcxw71+release FLASH 695776 695776 0 0.0
RAM 61776 61776 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1681812 1681812 0 0.0
RAM 214204 214204 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1596292 1596292 0 0.0
RAM 211372 211372 0 0.0
light cy8ckit_062s2_43012 FLASH 1460900 1460900 0 0.0
RAM 197808 197808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1494844 1494844 0 0.0
RAM 225688 225688 0 0.0
qpg lighting-app qpg6200+debug FLASH 838840 838840 0 0.0
RAM 127992 127992 0 0.0
lock-app qpg6200+debug FLASH 776608 776608 0 0.0
RAM 118944 118944 0 0.0
realtek light-switch-app rtl8777g FLASH 709488 709488 0 0.0
RAM 107204 107204 0 0.0
lighting-app rtl8777g FLASH 758168 758168 0 0.0
RAM 127336 127336 0 0.0
stm32 light STM32WB5MM-DK FLASH 470800 470800 0 0.0
RAM 141400 141400 0 0.0
telink bridge-app tl7218x FLASH 704552 704552 0 0.0
RAM 90772 90772 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 790846 790846 0 0.0
RAM 41200 41200 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 782212 782212 0 0.0
RAM 93872 93872 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710664 710664 0 0.0
RAM 52244 52244 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 746496 746496 0 0.0
RAM 71268 71268 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 721148 721148 0 0.0
RAM 34972 34972 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602962 602962 0 0.0
RAM 117760 117760 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815720 815724 4 0.0
RAM 92260 92260 0 0.0

github-actions[bot] avatar Dec 08 '25 16:12 github-actions[bot]

PR #41772: Size comparison from adfa2363e5537a84e9095c18ecfc33ec63338d2d to 40e07ed8ca54ac15b585164c5981927bf2024029

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section adfa2363 40e07ed8 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1105616 1105616 0 0.0
RAM 178970 178970 0 0.0
bl702 lighting-app bl702+eth FLASH 660708 660708 0 0.0
RAM 135041 135041 0 0.0
bl702+wifi FLASH 836292 836292 0 0.0
RAM 124501 124501 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070018 1070018 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 902642 902642 0 0.0
RAM 105948 105948 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983020 983020 0 0.0
RAM 109876 109876 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770680 770680 0 0.0
RAM 103400 103400 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 783692 783692 0 0.0
RAM 108728 108728 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728708 728708 0 0.0
RAM 97468 97468 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713284 713284 0 0.0
RAM 97676 97676 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554540 554540 0 0.0
RAM 205480 205480 0 0.0
lock CC3235SF_LAUNCHXL FLASH 588416 588416 0 0.0
RAM 205736 205736 0 0.0
efr32 lock-app BRD4187C FLASH 964880 964880 0 0.0
RAM 123808 123808 0 0.0
BRD4338a FLASH 759312 759312 0 0.0
RAM 254404 254404 0 0.0
window-app BRD4187C FLASH 1060292 1060284 -8 -0.0
RAM 120004 120004 0 0.0
esp32 all-clusters-app c3devkit DRAM 102820 102820 0 0.0
FLASH 1830466 1830466 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 936020 936020 0 0.0
RAM 161736 161736 0 0.0
nxp contact mcxw71+release FLASH 695416 695416 0 0.0
RAM 61776 61776 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1680884 1680884 0 0.0
RAM 214204 214204 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1595388 1595388 0 0.0
RAM 211372 211372 0 0.0
light cy8ckit_062s2_43012 FLASH 1460060 1460060 0 0.0
RAM 197808 197808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1494140 1494140 0 0.0
RAM 225688 225688 0 0.0
qpg lighting-app qpg6200+debug FLASH 837996 837996 0 0.0
RAM 127992 127992 0 0.0
lock-app qpg6200+debug FLASH 775980 775980 0 0.0
RAM 118944 118944 0 0.0
realtek light-switch-app rtl8777g FLASH 709000 709000 0 0.0
RAM 107204 107204 0 0.0
lighting-app rtl8777g FLASH 757408 757408 0 0.0
RAM 127336 127336 0 0.0
stm32 light STM32WB5MM-DK FLASH 470048 470048 0 0.0
RAM 141400 141400 0 0.0
telink bridge-app tl7218x FLASH 704336 704336 0 0.0
RAM 90772 90772 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 790494 790494 0 0.0
RAM 41208 41208 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 781858 781858 0 0.0
RAM 93872 93872 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710474 710474 0 0.0
RAM 52244 52244 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 746306 746306 0 0.0
RAM 71268 71268 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 720960 720960 0 0.0
RAM 34972 34972 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602602 602602 0 0.0
RAM 117768 117768 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815376 815380 4 0.0
RAM 92260 92260 0 0.0

github-actions[bot] avatar Dec 08 '25 23:12 github-actions[bot]