connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

[Device Energy Management Mode Cluster] Device Energy Management Mode Cluster XML has to be updated as per Spec

Open Ashwinigrl opened this issue 1 year ago • 3 comments

Description:

  • [ ] 1. Below following Feature and Attributes are Disallowed for the Device Energy Management Mode Cluster. So these should be removed from the Device Energy Management Mode Cluster device XML.

Feature:

  1. OnOff

Attributes:

  1. StartUpMode
  2. OnMode

Spec Reference:

  • https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/Mode_DeviceEnergyManagement.adoc#4-features

image

image

XML References:

  • https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/device-energy-management-mode-cluster.xml

image

image

  • [ ] 2. In Spec, Device Energy Management Mode Cluster Revision value has been updated from 1 to 2. So XML has to be updated as per the spec.

Spec Reference:

  • https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/Mode_DeviceEnergyManagement.adoc#1-revision-history

image

XML References:

  • https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/device-energy-management-mode-cluster.xml#L51

image

Ashwinigrl avatar Oct 14 '24 07:10 Ashwinigrl

Data model XMLs are updated automatically and aligned to spec tags. These data model XMLs will be updated when the spec tag for the board release is tagged. These data model files are automatically generated and should not be updated by hand.

They don't need individual issues opened.

Closing this as it will be fixed once the spec is properly tagged and I don't want anyone thinking they need to make hand edits.

cecille avatar Oct 16 '24 21:10 cecille

Data model XMLs are updated automatically and aligned to spec tags

This is not about data model XMLs, which are under /data_model. This is about a file under /src/app/zap-templates/zcl/data-model/chip.

bzbarsky-apple avatar Oct 18 '24 21:10 bzbarsky-apple

PR here to fix: #36155

jamesharrow avatar Oct 18 '24 23:10 jamesharrow