connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

added clean build option using --clean flag in efr32_examples

Open lpbeliveau-silabs opened this issue 2 years ago • 2 comments

Adds a new flag to do a clean build up when specifying : --clean when using the gn_efr32_example.sh script to build examples.

lpbeliveau-silabs avatar Oct 24 '22 15:10 lpbeliveau-silabs

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 24 '22 15:10 CLAassistant

Why are we not just using scripts/build/build_examples.py. That script has standardised arguments across many platforms and in particular will support --clean.

It is difficult to maintain several different scripts with several different arguments. As a core developer, remembering each argument for scripts/examples (I see android, efr32, psoc6, k32w, imxlinx, webos, nrfconnect, boufallolab there) is tedious.

@andy31415 We do maintain build_examples.py for the Silabs platform also and yes it is standardized and for stuff like CI, it is great. However, it doesn't allow as much flexibility for us. Each combination of arguments becomes a new string in the target name and It becomes even more tedious to remember the naming. If you type a wrong target name you get an error message and it prints hundreds of target names for every platform and argument combination.

With our own script that we maintain, we can provide presets that we do want to showcase but also complete flexibility in any arguments you would want to add or remove.

jmartinez-silabs avatar Oct 24 '22 17:10 jmartinez-silabs

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 21 '23 04:02 stale[bot]