connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

[BUG] ZAP bootstrap is failing due to old version of Node in PW.

Open krypton36 opened this issue 2 years ago • 5 comments

Reproduction steps

1. Clone connectedhomeip on macOS
2. source ./scripts/activate.sh
3. ./scripts/tools/zap/zap_bootstrap.sh
...

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

bd5956dc76adca4285c5380462ad249501a3b6d8

Platform

darwin

Platform Version(s)

No response

Anything else?

NodeJs in PW is obsolete and needs to be updated since October 4th. 2022-10-19T16_33_50_481Z-debug-0.log

krypton36 avatar Oct 19 '22 16:10 krypton36

@krypton36 - what does which node and which npm say before/after each step? I don't think pigweed has anything to do with node in general (it handles python and c++ as far as I am aware)

andy31415 avatar Oct 19 '22 16:10 andy31415

which node: /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/node which npm: /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/npm

krypton36 avatar Oct 19 '22 17:10 krypton36

± /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/node --version v18.4.0

± /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/npm --version 8.12.1

○ /usr/local/bin/node --version v16.18.0

krypton36 avatar Oct 19 '22 17:10 krypton36

Temporary Workaround: Run scripts/tools/zap/zap_bootstrap.sh outside of source ./scripts/activate.sh environment. Then, during ZAP code gen use system env and switch to compile.

krypton36 avatar Oct 19 '22 18:10 krypton36

Having a side conversation with pigweed about handling optionality in things.

Now that I went down this rabbit hole, it seems we bring in other things like cmake and doxygen (both of which we install in our images anyway and generally do not use).

It seems that if we get things optional, we may be able to speed up bootstrap, which would be a nice win.

andy31415 avatar Oct 19 '22 19:10 andy31415

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Apr 19 '23 14:04 stale[bot]

This stale issue has been automatically closed. Thank you for your contributions.

stale[bot] avatar Apr 30 '23 10:04 stale[bot]