connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

Remove the vestiges of emberAfGetNodeId

Open bzbarsky-apple opened this issue 4 years ago • 4 comments

Problem

The only use of emberAfGetNodeId in the cluster code we pulled in was in message.c, to set emberAfResponseDestination to "ourselves". We just hardcoded it to 0 instead, so we don't have to pull in a definition of emberAfGetNodeId.

Proposed Solution

Once https://github.com/project-chip/connectedhomeip/pull/1915 lands, emberAfResponseDestination won't be a node id at all, so the declaration and commented-out call to emberAfGetNodeId can go away. That said, we'll need to figure out what emberAfClearResponseData should do with emberAfResponseDestination. Maybe nulling it out and adding null-checks in the places where it's used is reasonable.

bzbarsky-apple avatar Jul 31 '20 17:07 bzbarsky-apple

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.77. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jul 31 '20 17:07 issue-label-bot[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Oct 22 '21 06:10 stale[bot]

This is still an issue.

bzbarsky-apple avatar Oct 27 '21 18:10 bzbarsky-apple

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 16 '22 22:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 23 '23 00:03 stale[bot]