connectedhomeip
connectedhomeip copied to clipboard
If no attribute and event data encoded successfully, we should send status report instead of drop out
Context is from
Originally posted by @bzbarsky-apple in https://github.com/project-chip/connectedhomeip/pull/13400#discussion_r794897876
Fix the logic here if (!hasEncodedAttributes && !hasEncodedEvents && hasMoreChunks) { ChipLogError(DataManagement, "No data actually encoded but hasMoreChunks flag is set, abort report! (attribute too big?)"); ExitNow(err = CHIP_ERROR_INCORRECT_STATE); }
In particular, we should probably do a path-specific status for whatever path it was that did not fit in the packet.
RESOURCE_EXHAUSTED seems like a good status to use here.
Spec Review: @mrjerryjohns to review.
Chatted with @bzbarsky-apple , punting for post v1.0 since it's not really needed, and adding more logic here may introduce more bugs than is worth.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.