connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

If no attribute and event data encoded successfully, we should send status report instead of drop out

Open yunhanw-google opened this issue 3 years ago • 5 comments

Context is from

Originally posted by @bzbarsky-apple in https://github.com/project-chip/connectedhomeip/pull/13400#discussion_r794897876

Fix the logic here if (!hasEncodedAttributes && !hasEncodedEvents && hasMoreChunks) { ChipLogError(DataManagement, "No data actually encoded but hasMoreChunks flag is set, abort report! (attribute too big?)"); ExitNow(err = CHIP_ERROR_INCORRECT_STATE); }

yunhanw-google avatar Jan 29 '22 03:01 yunhanw-google

In particular, we should probably do a path-specific status for whatever path it was that did not fit in the packet.

bzbarsky-apple avatar Jan 29 '22 04:01 bzbarsky-apple

RESOURCE_EXHAUSTED seems like a good status to use here.

bzbarsky-apple avatar Feb 15 '22 06:02 bzbarsky-apple

Spec Review: @mrjerryjohns to review.

woody-apple avatar May 26 '22 17:05 woody-apple

Chatted with @bzbarsky-apple , punting for post v1.0 since it's not really needed, and adding more logic here may introduce more bugs than is worth.

mrjerryjohns avatar Jun 22 '22 00:06 mrjerryjohns

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 20 '22 18:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jun 24 '23 09:06 stale[bot]