Val Lorentz

Results 511 comments of Val Lorentz

Wouldn't an "Implementation considerations" section be a better fit?

Implemented in Matrix2051: https://github.com/progval/matrix2051/commit/e03f2be5f1dba14951158a0738dbee54f651f21b

@jwheare's opinion: 1. yes, conditioned to `draft/channel-rename` and `draft/event-playback` caps 2. no, ie. ``` :[email protected] PRIVMSG #newchan :let's rename it :[email protected] RENAME #oldchan #newchan :no reason :[email protected] PRIVMSG #newchan :nice...

(btw my server is Conduit's `next` branch)

That's because `{}` in the entry is inserted by `.replace("$longtitle", feed_title_str)`, and `.format()` tries to interpret it. Bitbot should probably remove `.format()` altogether and use to `string.Template`. See #370 as...

Hmm, that's a nasty side-effect of #76. `nom_locate` used to only support a limited set of `fragment` types that are well-behaved. But since that generalization, one can implement `AsBytes` on...

Well, I guess something like this would work: ```diff diff --git a/src/lib.rs b/src/lib.rs index 66a19f4..cd097f4 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -118,6 +118,12 @@ use nom::{ #[cfg(feature = "stable-deref-trait")] use...

Thanks for the benchmark. `nom_locate`'s overhead seems to be overwhelmingly in this function: https://github.com/fflorent/nom_locate/blame/c61618312d96a51cd7b957831b03dfbbcc5f58c7/src/lib.rs#L665-L691 with roughly a quarter in [`memchr`](https://docs.rs/memchr/latest/memchr/) and the rest in the function itself (and callgrind seems...

> introduce Rust in Thunderbird! While this is a brand new feature yay Rust, the feature I've been waiting for!

So what you're saying is that you want to rewrite this repo in TypeScript?