RSS allows adding announce multiple times

[Mikaela]

2014-12-30 10:01:42+0200 <@Mikaela> %rss announce add viestintavirasto
2014-12-30 10:01:42+0200 <@Dysforia> The operation succeeded.
2014-12-30 10:01:45+0200 <@Mikaela> %flush
2014-12-30 10:01:46+0200 <@Dysforia> The operation succeeded.
2014-12-30 10:01:48+0200 <@Mikaela> %rss announce add viestintavirasto
2014-12-30 10:01:48+0200 <@Dysforia> The operation succeeded.
2014-12-30 10:01:55+0200 <@Mikaela> %rss announce list
2014-12-30 10:01:56+0200 <@Dysforia> hsseksuaalivahemmistot, viestintavirasto, hstranssukupuolisuus, iskelma, puhku, heka, amnestyfi, mikaelafi, kapsitiedotteet, sadekondelin, kapsi, ylepaa, kymensanomat, podkaista, linucast, queeborgtumblr, ylekymenlaakso, tietoturvanyt, ktkhaavoittuvuudet, tumblrmikaela, mtv3, hssukupuolet, normitnurin, ja afterdawn

[bw4518]

Feature request? :)

It should just say "already added" or something.

[Mikaela]

I don't get notifications about the labels, but I would say "bug".

[bw4518]

Borderline maybe, as it won't actually break or mess up anything by adding it multiple times. :)

[Mikaela]

GitHub allows multiple labels to be set on issues, so it could be both, but that could look a little funny.

[jlu5]

To elaborate some more: technically this is a minor bug because the actually announcements aren't duplicated or anything. Internally the config value for plugins.rss.announce actually uses a set, which automatically filters away duplicate items. So, the real issue is that Limnoria doesn't error if the new feed is already in the set, and returns success regardless of whether the feeds were actually (re)added or not.