goroutine leak in Context.Run?

[ain-valtin]

It seems there is a goroutine leak in Context.Run: https://github.com/progrium/go-basher/blob/master/basher.go#L267 goroutine is launched which iterates over signals chan. But the chan is never closed, so the routine never exits... shouldn't there be something like

defer func() {
   signal.Stop(signals)
   close(signals)
}()

after signal.Notify(signals) call?

[josegonzalez]

Do you think https://github.com/progrium/go-basher/pull/23 would resolve it?

[ain-valtin]

No - the goroutine will still stay around until the signals chan is closed (which currently never happens).

[josegonzalez]

Hmmm I think that makes sense - @progrium thoughts? - and would take a PR :)