MobileIconChanger icon indicating copy to clipboard operation
MobileIconChanger copied to clipboard

ROG Phone 3 compatibility

Open jeanrivera opened this issue 3 years ago • 15 comments

It appears not compatible with my device stock A11 (R) Rom, I wonder if there is any kind of log I can provide you to help you find why it isn't compatible and if possible fix on a future release.

Obviously I have tried reboot after install, and tried disabling other modules that mess with SystemUI to make sure it wasn't a conflict issue.

Screenshot_20210701-002817847

I have uploaded a logcat while restarting the SystemUI and my systemUI apk logcat.txt https://drive.google.com/file/d/1WdDW2ea1JEluvCly4wRRpugcInyCZJbB/view?usp=sharing

jeanrivera avatar Jul 01 '21 04:07 jeanrivera

Did you enable the resource hooks? Are you using LSPosed or EdXposed?

programminghoch10 avatar Jul 01 '21 08:07 programminghoch10

Did you enable the resource hooks? Are you using LSPosed or EdXposed?

Yes and LSPosed

jeanrivera avatar Jul 01 '21 08:07 jeanrivera

some new development on the issue, now it does show me the icons to replace, but it does not replace them after systemUI reboot or after normal reboot.

I have attached screenshot and logcat

Screenshot_20210701-135046083

logcat.txt

jeanrivera avatar Jul 01 '21 17:07 jeanrivera

Please install version 2.2.1 and capture a logcat again. Your system seems to be compatible but the replacement code fails somehow. Version 2.2.1 has more debugging output and should give us more intel. If all does not work, it is probably because your system uses custom icons (compare it to the AOSP example screenshots; original android does not have activity indicators).

programminghoch10 avatar Jul 01 '21 22:07 programminghoch10

Please install version 2.2.1 and capture a logcat again. Your system seems to be compatible but the replacement code fails somehow. Version 2.2.1 has more debugging output and should give us more intel. If all does not work, it is probably because your system uses custom icons (compare it to the AOSP example screenshots; original android does not have activity indicators).

I guess it will not work for me :-( , I have sent my systemUI on the first post, but not sure if that will help at all

logcat.txt

jeanrivera avatar Jul 01 '21 23:07 jeanrivera

Do you want me to close this issue here and keep troubleshooting on XDA?

jeanrivera avatar Jul 02 '21 23:07 jeanrivera

No, I prefer it here. I had not yet the chance to look into the latest logcat, please give me some time.

programminghoch10 avatar Jul 03 '21 07:07 programminghoch10

Okay I looked at the logcat and I don't understand what happend there... The module loses track of the replacement icon at a point where that should not be possible... Anyways I've attached a test apk with even more logging output. (rename it to .apk first, github only let me upload zip files) MobileIconChanger-ROGPhone3test1.apk.zip Please also select one icon to be replaced by another system icon (select any icon from category system). Then as always, restart systemui while capturing a logcat.

Oh also I've already had a look at your SystemUI.apk, it all looks to be compatible.

programminghoch10 avatar Jul 03 '21 12:07 programminghoch10

thanks for your time and for trying to debug this issue, here is the new logcat, still not working for me logcat.txt

jeanrivera avatar Jul 03 '21 21:07 jeanrivera

This is very weird. The code runs normally and replaces everything as it should do. The execution time is a bit wanky, but I don't think that is a problem. It will be very hard to debug this issue further without the phone at hand.

You can try one more thing, as I said in the last comment

Please also select one icon to be replaced by another system icon (select any icon from category system).

If that works, maybe there is still a chance.

programminghoch10 avatar Jul 05 '21 10:07 programminghoch10

This is very weird. The code runs normally and replaces everything as it should do. The execution time is a bit wanky, but I don't think that is a problem. It will be very hard to debug this issue further without the phone at hand.

You can try one more thing, as I said in the last comment

Please also select one icon to be replaced by another system icon (select any icon from category system).

If that works, maybe there is still a chance.

The last log I provided is replacing icons with system icons already, I think we have hit a wall with this issue. If there is nothing else we can do about it, let me know if you want me to close this issue

jeanrivera avatar Jul 05 '21 10:07 jeanrivera

You did replace some with system icons, but the code for replacing them did not run. I think that the replacement code only is run when the icon is actually accessed by the system. Can you try replacing an icon where you can actually observe if it changes?

Yes you are right it looks like we've hit a wall. But you do know I can also close the issue myself? Or you can just close it when you think it's not worth your time examining further. Either way there is no need to hurry.

programminghoch10 avatar Jul 05 '21 12:07 programminghoch10

Either way there is no need to hurry.

I am not in a hurry and willing to provide any logs you need or other system files as request, and also test more for you when needed, if you come up with another idea or require any other logs please let me know.

jeanrivera avatar Jul 05 '21 23:07 jeanrivera

Can you try replacing an icon where you can actually observe if it changes?

and upload another logcat and this file: /data/misc/lspd_sB5BapCTQS5o5h0W/prefs/com.programminghoch10.mobileiconchanger/mobileIconChanger.xml

programminghoch10 avatar Jul 17 '21 20:07 programminghoch10

mobileIconChanger.xml.zip

It's fake .zip not an actual archive just delete the .zip at the end

jeanrivera avatar Jul 17 '21 20:07 jeanrivera