jekyll icon indicating copy to clipboard operation
jekyll copied to clipboard

publishing translation of introduction to map warper

Open hawc2 opened this issue 2 years ago • 4 comments

@svmelton hopefully this one goes a little smoother

Checklist

  • [ ] Assign yourself in the "Assignees" menu
  • [ ] Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • [ ] Add the appropriate "Label"
  • [ ] Ensure the status checks pass
  • [ ] Check the live preview of your PR on Netlify
  • [ ] If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

hawc2 avatar Aug 18 '22 02:08 hawc2

@svmelton actually let's hold off on merging this. I got the basic stuff set up, but I discovered that some of the liquid syntax isn't properly rendering the gifs and other images, so I'll want to figure this out before we merge and publish

hawc2 avatar Aug 18 '22 02:08 hawc2

thanks @svmelton. on this one i might need to wait for @anisa-hawes to return to make sure we're in agreement about the right way to link the gifs . . .

hawc2 avatar Aug 21 '22 20:08 hawc2

Hello @hawc2. Thank you for asking about the .gifs. I'm not certain what is causing this problem. The Create an Account .gif in the Getting Started section (l.75 of the Markdown) still works as it should.

I noticed that the tiny icon images no longer displayed 'inline' with the text when I added in the liquid syntax. If we want to keep the icons, and display them inline, I think we might need to add the ![text](link) formatting back in.

I know that liquid syntax can work with .gifs because I checked the code for an ES lesson that I remembered includes them: Análisis de corpus con Voyant Tools. The Markdown for that lesson is here.

--

Reviewing my comment in the Issue thread and double checking the recent commit history, it looks like we are still waiting for the authors to make the other small changes, or reply with their responses to those suggestions.

anisa-hawes avatar Sep 01 '22 15:09 anisa-hawes

Ok, thanks @anisa-hawes - I'll wait until the final edits are made based on our discussion on the lesson ticket. After they finalize the lesson on ph-submissions, I'll update this branch, and then we can hopefully go forward with this pull request

hawc2 avatar Sep 02 '22 01:09 hawc2

@svmelton, the authors are still trying to figure out how to edit the gifs to render correctly. Should we close this and I can start a new pull request when it's ready?

hawc2 avatar Sep 27 '22 13:09 hawc2

@svmelton, the authors are still trying to figure out how to edit the gifs to render correctly. Should we close this and I can start a new pull request when it's ready?

Yes, that sounds good!

svmelton avatar Sep 28 '22 03:09 svmelton