cb2
cb2 copied to clipboard
CB2 stays half open forever after being tripped open once
Hi It looks like CB2 can never become fully closed after being opened once. Here's a failing test.
The rolling window strategy's #half_open?
is pretty much the opposite of #open?
, which is not what it is supposed to represent.
I was thinking of having a success
callback in a strategy, which would reset last_open
if the circuit breaker is currently half-open. This would solve the issue in a single-threaded case, although in a hacky manner, but there are going to be issues with concurrent clients (cranking up number of WORKERS
in the test to 50 or so exposes the issue).
I think this is closeable now?
@pedro
Looks like this was fixed in v0.0.3