progit2-ja icon indicating copy to clipboard operation
progit2-ja copied to clipboard
verified publisher icon progit

Insert spaces around backticks for markups to be correctly detected

Open noritada opened this issue 3 years ago • 1 comments

Hi,

This is a series of corrections for issues that some markups are not detected in following sections:

  • book/02-git-basics/sections/recording-changes.asc HTML
  • book/09-git-and-other-scms/sections/import-svn.asc HTML
  • book/A-git-in-other-environments/sections/*.asc HTML
  • book/B-embedding-git/sections/jgit.asc HTML

Could you please review?

Many thanks

noritada avatar Jan 22 '22 09:01 noritada

@tnir Thank you very much for review comments and I'm sorry for my missing explanations.

I made this change because when multiple pairs of this markup are included, like ``foo'' and ``bar'', AsciiDoctor recognizes that foo'' and is the content of quotes of `` and wrongly highlights those words. I investigated this issue and found that AsciiDoctor's curved quotation syntax seems to have been changed from ``foo'' to `"foo"` in v1.5.0, and this book's English version has already been changed to the new syntax. For this reason, I made corresponding changes in this PR to avoid highlighting issues.

However, I myself respect the original Japanese translation, so if there is any problem, I would like to revert to the original syntax. Could you give me a suggestion on which is better?

noritada avatar Mar 25 '22 08:03 noritada