elpaca
elpaca copied to clipboard
Mostly sync with MELPA :version-regexp
-
This regexp differs slightly from MELPA's version because it excludes %p, where they would substitute the package name, enabling tags like "elpaca-0.2" if the package is named elpaca.
If you want, I can sub it in with some
(plist-get recipe ...). But maybe this forms a sort of natural boundary, for how smart the version inference should be in the first place. It's convenient to keep it self-contained in the regexp. -
Let me know if you want me to remove the comment line.
While it does not affect this PR right now, I saw something possibly concerning/complicating. Custom regexps can apparently have %v and %p, examples seen in https://github.com/melpa/melpa/commit/f9103b6c58996e75c0e5c23fc0fb12afd65424c0
Not sure if elpaca handles that yet?
For reference, the transformations seem to be done by the function package-build--version-regexp at https://github.com/melpa/package-build/blob/master/package-build.el
It does seem like a headache for all downstream package managers to be aware of and handle :version-regexp. At a knee jerk, it would've made more sense to me if Melpa just limited the set of permissible tag formats and made it non-customizable, but I haven't thought much about it.
This regexp differs slightly from MELPA's version
That's fine. I'm not interested in strict MELPA compatibility. Elpaca is designed to work with many different ELPA's information.
Let me know if you want me to remove the comment line.
Yes please.
Custom regexps can apparently have %v and %p, examples seen in melpa/melpa@f9103b6 Not sure if elpaca handles that yet?
Nope. That would be something to add to elpaca-menu-melpa.el, if at all.
it would've made more sense to me if Melpa just limited the set of permissible tag formats and made it non-customizable
IMO semver should be the only scheme, but it's too late for that.
Done.
semver should be the only scheme
Or EffVer :) https://jacobtomlinson.dev/effver/ But it looks the same, anyway.
Merged. Thanks.
This PR seems to have caused new problems?
It will always be blocked here
I forked elpaca and tried to roll back to the previous commit, but it was still blocked.
Sorry, please ignore the above statement, it seems to be my network problem
@jinzhongjia please read this prior to requesting support:
https://github.com/progfolio/elpaca/wiki/Troubleshooting
These sections in particular:
https://github.com/progfolio/elpaca/wiki/Troubleshooting#check-your-network-connection https://github.com/progfolio/elpaca/wiki/Troubleshooting#prefer-text-over-screenshots
Thanks
@jinzhongjia please read this prior to requesting support:
These sections in particular:
Wiki: Troubleshooting (check your network connection) Wiki: Troubleshooting (prefer text over screenshots)
Thanks
No intention to disturb, but I need to explain that the above blocking problem is because gnu cannot be accessed for several hours in the past, which has resulted in constant blocking.