Add configurable timeout for stop_trace

[ijcd]

This is working for me. I'm less familiar with erlang, so it might not be idiomatic. I looked into using proplists for the Options argument, but it doesn't seem to have a convenient guard that would work. Using a map, the calling syntax from Elixir is not idiomatic, but I'm not sure that matters.

Feedback welcome.

Fixes https://github.com/proger/eflame/issues/13

[proger]

Thanks for your contribution! I wonder if it would make sense to move the rest of the options (Mode and OutputFile) into your Options map as well. Or, for consistency, just add Timeout as an extra argument and export it as apply/5.

[ijcd]

If there are other options already (that have a reasonable default) it would make sense to merge options together I think. I didn't notice that the other things you mention were options. I would reserve args for required values -- especially since Erlang doesn't have things like default values, etc... all of the function head variations look to get out of hand pretty quickly...

--Ian

On Wed, Oct 25, 2017 at 6:03 AM, Vlad Ki [email protected] wrote:

Thanks for your contribution! I wonder if it would make sense to move the rest of the options (Mode and OutputFile) into your Options map as well. Or, for consistency, just add Timeout as an extra argument and export it as apply/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/proger/eflame/pull/15#issuecomment-339322657, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAveUDiX9a6RiwuYQ3UrCymCFvNVmxeks5svzG0gaJpZM4QCIaa .

[Hajto]

Is this PR alive? If original author is not interested in finishing this, I could contribute.

[ijcd]

I would welcome that. I used this for a quick project and opened the PR in case it was useful to someone. I won’t be able to add to it anytime soon.

—Ian

On Thu, Feb 4, 2021 at 3:11 AM Jakub Hajto [email protected] wrote:

Is this PR alive? If original author is not interested in finishing this, I could contribute.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/proger/eflame/pull/15#issuecomment-773228326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAC66IYRM4CGDSFKBEXBD3S5J6E5ANCNFSM4EAIQ2NA .