sgqlc icon indicating copy to clipboard operation
sgqlc copied to clipboard

Python 3.5 support

Open dzhu opened this issue 5 years ago • 4 comments

I would like to use sgqlc for a project that is currently committed to supporting Python 3.5 (among other versions). Would it be possible to add Python 3.5 support to sgqlc? I'm hoping it might not be a huge amount of work: I haven't done a thorough check, but I was able to install sgqlc, run sgqlc-codegen, and use the generated code to make some queries after very minimal changes to the code -- I just had to edit setup.py to change the version requirement and remove the one use of an f-string. It does look like getting the tests to run will be take a bit more tweaking, though.

dzhu avatar Feb 04 '20 21:02 dzhu

I never bothered to check, if the f-strings are the only issue, I'm fine to apply patches converting to more traditional string formatting.

barbieri avatar Feb 04 '20 22:02 barbieri

Thanks! But sorry, I'm not quite clear -- are you intending to work on this yourself or are you saying that PRs would be welcome?

dzhu avatar Feb 05 '20 02:02 dzhu

PRs would be welcome :-)

quite overloaded with work these days, not able to work on it myself.

barbieri avatar Feb 05 '20 13:02 barbieri

Sounds good. I'll take a look.

dzhu avatar Feb 05 '20 17:02 dzhu