apollo-federation-file-upload icon indicating copy to clipboard operation
apollo-federation-file-upload copied to clipboard

Upgrade to Apollo Server 4

Open veimox opened this issue 1 year ago • 5 comments

➕ Enhancement Request

Apollo Server 4 changes how the packages are distributed. There is a migration guide that can be followed. It is basically to change the package names where the imports are coming from.

Problem related to enhancement request

By not doing this, there is a risk being obsolete or forcing users of this library to install libraries that they wouldn't do otherwise.

Sought-for solution

  • #55 Could be the solution but I would rather doing it separately to make smaller changes. That PR has been open for basically a year so I really think is time to merge that one anyways.

Considered alternatives

  • Making a PR on top of #55 but I would rather wait
  • Updating the README.md to state the limitations

veimox avatar Mar 18 '23 17:03 veimox

For Apollo 4, I will have to do some further adaptations in the code, since the built-in apollo upload was removed. https://www.apollographql.com/docs/apollo-server/v2/data/file-uploads/#uploads-in-node-14-and-later

And we will add instructions about this CSRF attack prevention.

g7fernandes avatar Mar 21 '23 12:03 g7fernandes

Hey all, just checking in if v4 upgrade is planned or if this package is compatible with v4.

amilich avatar Oct 21 '23 20:10 amilich

No update :'( ?

amilich avatar Dec 20 '23 23:12 amilich

any update on this for apollo server 4?

gwachhamit avatar Jun 07 '24 07:06 gwachhamit

Hello good morning everyone, any news about the upgrade to Apollo 4?

hugocruzlfc avatar Sep 05 '24 09:09 hugocruzlfc

I found this code that worked for my purpose. I'm using this code with NestJs.

https://gist.github.com/bl42/881d85ee0dd92bbe68e93dcd0c99cfdb

My libs versions: "@apollo/federation": "^0.38.1", "@apollo/gateway": "^2.9.1", "@apollo/server": "^4.11.0", "@apollo/subgraph": "^2.9.1",

newerton avatar Oct 12 '24 23:10 newerton