ProffieOS
ProffieOS copied to clipboard
profezzorn
CI/CD
Hey mates, its been a long time since I played with sabers, but recently had the luck to fetch the master and had broken compilation on that commit. Do you all agree, that we can actually setup a travisCI and some CI on pull request just to check compilation health, and presumably can run some other tests in the future? I know that it might be overkill and the hobby starts to look like work , but sure can probably help with overall quality and automation of releases and testing.
Sure, but what did you try to compile? There is no way to test every possible configuration in CI, so maybe the issue is more about unusual configurations than about not enough testing? We have some CI already, but it's all POSIX, so no platform-specific stuff:
https://github.com/profezzorn/ProffieOS/blob/master/.github/workflows/RunTests.yml
If you're referring to CONFIG_FILE being undefined, that's intentional to make users select a config file.
On Fri, Feb 11, 2022 at 3:21 AM Boyko Kazakov @.***> wrote:
The issue was something trivial: commented config file. But it was on master, which I presume is the production branch that is unstable but buildable. And as contribution grows, automatic the PRs with some form of compilation check will be the good start, although about the configuration topic, most problems will come from the teensy platform, as it will be quite nightmerish to make travisCI work with it. But just having a CI pipeline for the proffiboards only as it is a platform that is with its own arduino platform repo, it might be easier to make.
— Reply to this email directly, view it on GitHub https://github.com/profezzorn/ProffieOS/issues/406#issuecomment-1036102611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASXSBNZM2DDLM3JY27KX2LU2TWLFANCNFSM5OBX7PYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>