Linshu Yang comments

Results 54 comments of


                                            Linshu Yang

Fix `match_single_binding` wrongly handles scope

@samueltardieu #15269 is fixed in this PR now

Fix `match_single_binding` wrongly handles scope

Updated. Thank you!

Fix `match_single_binding` wrongly handles scope

Any feedback? @dswij

`zero_repeat_side_effects` would require `never_type` which is not stable yet

@rustbot claim

unnecessary_fallible_conversions can't `into` a `Result`, missing trait impl

@rustbot claim

unnecessary_fallible_conversions can't `into` a `Result`, missing trait impl

From the lint's description: ```rust let _: Result = 1i32.try_into(); let _: Result = ::try_from(1i32); // Use `from`/`into` instead: let _: i64 = 1i32.into(); let _: i64 = ::from(1i32); ```...

Fix `never_loop` forget to remove `break` in suggestion

Updated. Thank you!

Fix `never_loop` forget to remove `break` in suggestion

@rustbot ready

Fix `iter_on_single_items` FP on function pointers and let stmts

r? clippy

Fix `iter_on_single_items` FP on function pointers and let stmts

r? samueltardieu