glab icon indicating copy to clipboard operation
glab copied to clipboard

[GLAB]: Accept merge request contributions for `glab` on GitLab

Open profclems opened this issue 4 years ago • 10 comments

Since the time I open-sourced glab till now, most users or [just] critics have raised their concerns and some criticized me for hosting a command line tool intended for GitLab on GitHub.

I started working on glab earlier before GitHub announced gh in beta stages. I will say I actively use both GitHub and GitLab. I use GitHub for personal projects (mostly) and GitLab at work.

glab was initially just a basic tool for my personal use. I just wanted to use it to create issues, merge request and be able to merge them. I used it for a while and introduced it to a friend, @wil-power who suggested that I make it open source and receive contributions.

I have thought about this for a while and it seems that a complete move to GitLab, though is entirely possible, other contributors prefer to contribute to FOSS on GitHub.

The alternative here is to accept merge request contributions on GitLab, which will be merged via CI to the GitHub repo.

We already accept issues on GitLab #524 and these are automatically cloned as GitHub issues.

profclems avatar Mar 25 '21 17:03 profclems

Here are a few things we need to do:

  • [ ] Enable merge requests on the GitLab Mirror (https://gitlab.com/profclems/glab)
  • [ ] GitLab CI / GitHub Action workflow to merge merge request after it has been approved (#525)
  • [ ] sync MR events such as:
    • [ ] Labeled
    • [ ] Unlabeled
    • [ ] Commented
    • [ ] Closed
    • [ ] Reopened
  • [ ] Update documentation

profclems avatar Mar 25 '21 17:03 profclems

As a popular project in the GitLab community, I would love to see this project accept MRs on GitLab. Let me know if there's anything we can do to help.

johncoghlan avatar Mar 25 '21 19:03 johncoghlan

Thanks @johncoghlan...

Just want to know if it's possible to trigger GitLab CI job on MR events like 'on approval'?. I will need help in setting up the CI to trigger merge action for merge request on approval if that's possible.

It's been more than 7 months since I opened a merge request for glab to be added to GitLab's CLI partners. The original MR (https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/59953) was closed by Amy Brandenburg and recreated as https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/64177 but has not been merged yet. Is there any reason this has delayed?

profclems avatar Mar 26 '21 07:03 profclems

Re: triggering GitLab CI - happy to help. By on approval, do you mean when you okay the MR and merge it into the main branch? I ask because we also have a merge requests approval feature.

Re: being added to CLI partners - I think the MR looks good. Such a popular tool definitely belongs there. I just commented on the MR and will work with Mike to see what the hold up is. Sorry about the delay. Amy left GitLab so perhaps that contributed to the delay.

johncoghlan avatar Mar 26 '21 18:03 johncoghlan

This is quite a difficult decision to take but I think it will be best if leave this repository as read only mirror and continue development on GitLab. It would be great accepting PRs and MRs both on GitHub and GitLab respectively, but that would be a tedious work as a maintainer.

cc: @zemzale @maxice8... Your thoughts??

profclems avatar May 14 '21 05:05 profclems

No objections

maxice8 avatar May 14 '21 07:05 maxice8

No objections too

zemzale avatar May 14 '21 07:05 zemzale

Okay so v1.17.0 will be the last glab release done on GitHub.

@johncoghlan is there a way we can import GitHub releases and issues to our existing repository on GitLab? At least to prevent people from losing their forks on GitLab

profclems avatar May 14 '21 14:05 profclems

This is great. You can read our docs on importing from GitHub to GitLab here: https://docs.gitlab.com/ee/user/project/import/github.html

A couple things to highlight from that page:

The following aspects of a project are imported:

Repository description (GitLab.com & 7.7+)
Git repository data (GitLab.com & 7.7+)
Issues (GitLab.com & 7.7+)
Pull requests (GitLab.com & 8.4+)
Wiki pages (GitLab.com & 8.4+)
Milestones (GitLab.com & 8.7+)
Labels (GitLab.com & 8.7+)
Release note descriptions (GitLab.com & 8.12+)
Pull request review comments (GitLab.com & 10.2+)
Pull request reviews (GitLab.com & 13.7+)
Pull request “merged by” information (GitLab.com & 13.7+)
Regular issue and pull request comments
Git Large File Storage (LFS) Objects 

If there are folks who are working on the project that you would like to map from GitHub to GitLab, they should review this section

Before you begin, ensure that any GitHub users who you want to map to GitLab users have either:

A GitLab account that has logged in using the GitHub icon - or -
A GitLab account with an email address that matches the publicly visible email address in the profile of the GitHub user 

User-matching attempts occur in that order, and if a user is not identified either way, the activity is associated with the user account that is performing the import.

johncoghlan avatar May 14 '21 14:05 johncoghlan

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

clemsbot avatar Jun 16 '21 02:06 clemsbot